Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer) : As a user, I want the Search feature to redirect me to the Subject page #792

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Nov 4, 2024

What does this PR do?

It redirects to subject page when search results only contains attestations related to subject

Related ticket

Fixes #751

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

Copy link
Contributor

github-actions bot commented Nov 4, 2024

@github-actions github-actions bot temporarily deployed to pull request November 4, 2024 11:21 Inactive
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.64%. Comparing base (5863e88) to head (59d86fc).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #792   +/-   ##
=======================================
  Coverage   46.64%   46.64%           
=======================================
  Files          18       18           
  Lines         388      388           
  Branches       57       57           
=======================================
  Hits          181      181           
  Misses        205      205           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satyajeetkolhapure satyajeetkolhapure merged commit 316d91f into dev Nov 4, 2024
11 checks passed
@satyajeetkolhapure satyajeetkolhapure deleted the feat/as-a-user-i-want-the-search-feature-to-redirect-me-to-the-subject-page branch November 4, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want the Search feature to redirect me to the Subject page
3 participants